search

MycroftAI / mycroft-skills

A repository for sharing and collaboration for third-party Mycroft skills development.
https://mycroft.ai/skills
756 stars 869 forks source link

Add todays-Gospel #1629

Closed tomascardososerra closed 2 years ago

tomascardososerra commented 2 years ago

Info

This PR adds the new skill, todays-Gospel, to the skills repo.

Description

This is a mycroft skill that will play the appropriate liturgic day gospel reading

Created with mycroft-skills-kit v0.3.16

krisgesling commented 2 years ago

Hi there,

Thanks for submitting your first Skill! :tada:

A few quick noticings:

To be included in the Marketplace the Skill goes through three reviews by our Skill Testing Team. You can read more about these reviews and the overall Skills Acceptance Process here: https://mycroft.ai/documentation/skills/skills-acceptance-process/

If you have any updates in the meantime, you can update this pull request by running: mycroft-msk submit /opt/mycroft/skills/your-skill-dir

Also feel free to post here or in the Skills channel on Chat if you have any questions.

Looking forward to trying out your Skill :slightly_smiling_face:

tomascardososerra commented 2 years ago

Thanks! Added the suggested improvements

tomascardososerra commented 2 years ago

Hi Kris, Thanks for your review and feedback. I have submitted a new version fixing the pending actions. Please let me know in case of any doubt.

Regards, Tomás

On 5 Jul 2022, at 03:22, Kris Gesling @.***> wrote:

Hi there,

Thanks for submitting your first Skill! 🎉

A few quick noticings:

You only need either requirements.txt or the manifest.yml not both. Given it only needs Python dependencies I'd probably stick with requirements.txt The official beautiful soup package name is beautifulsoup4 https://pypi.python.org/pypi/beautifulsoup4. See here for more details: https://pypi.org/project/bs4/ https://pypi.org/project/bs4/ Looks like there are no settings, so you can delete the settingsmeta.yaml file. It's a good idea to include a couple of simple integration tests. These get run by our continuous integration systems to make sure that the Skill is working as intended not only now, but into the future as other Skills are added into the ecosystem and Mycroft itself evolves over time. If you intend on extending this Skill over time this can also speed up your development time as you don't need to manually test all the functionality of a Skill each time you make a change to the code. More info on those here: https://mycroft-ai.gitbook.io/docs/skill-development/voight-kampff/test-steps https://mycroft-ai.gitbook.io/docs/skill-development/voight-kampff/test-steps To be included in the Marketplace the Skill goes through three reviews by our Skill Testing Team https://github.com/MycroftAI/contributors/blob/master/team/Skill-Testing-Team.md. You can read more about these reviews and the overall Skills Acceptance Process here: https://mycroft.ai/documentation/skills/skills-acceptance-process/ https://mycroft.ai/documentation/skills/skills-acceptance-process/ If you have any updates in the meantime, you can update this pull request by running: mycroft-msk submit /opt/mycroft/skills/your-skill-dir

Also feel free to post here or in the Skills channel on Chat https://chat.mycroft.ai/community/channels/skills if you have any questions.

Looking forward to trying out your Skill 🙂

— Reply to this email directly, view it on GitHub https://github.com/MycroftAI/mycroft-skills/pull/1629#issuecomment-1174498765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG52NNLDS7FOFCHWOEUH6T3VSOE4PANCNFSM52NN6H2A. You are receiving this because you authored the thread.