Add GUI to Alarm Skill - Githubissues

MycroftAI / skill-alarm

Mycroft AI official Alarm Skill - Set single and recurring alarms, with a choice of alarm sounds

https://mycroft.ai/skills

Apache License 2.0

14 stars 32 forks source link

Add GUI to Alarm Skill #113

Closed krisgesling closed 3 years ago

krisgesling commented 3 years ago

Description

Extension of PR #111 - adding new GUI to Alarm Skill courtesy of @AIIX

Title case for Alarm names
Switch display methods so that the less blocking QML display is first, then the blocking Mark 1 animation gets called. Hence the Skill appears more responsive on a Mark II.
Override_idle for expired alarms to show flashing screen until it is intentionally cleared.
Release GUI when expired alarm is stopped as no other Alarm screen should return at that time.

Note: requires this Fix in the Mark II Skill to work properly: https://github.com/MycroftAI/skill-mark-2/pull/59

Type of PR

[x] Feature implementation

Testing

Set an alarm
Wait for the new alarm screen to disappear
Wait for alarm to expire
wait for more than 30 seconds to show override idle is working
stop the expired alarm and should return to Homescreen.

Documentation

NA

CLA

[x] Yes

krisgesling commented 3 years ago

Hey Ken, I merged this against the skill_control branch and resolved the conflicts so that shouldn't cause any issues down the line now. Are you happy with the rest of it?