search

MycroftAI / skill-alarm

Mycroft AI official Alarm Skill - Set single and recurring alarms, with a choice of alarm sounds
https://mycroft.ai/skills
Apache License 2.0
14 stars 32 forks source link

require two keywords for adapt match #83

Closed krisgesling closed 4 years ago

krisgesling commented 4 years ago

As the intent only requires a single keyword, this can match anything with the word "alarms" in it.

Requiring a verb [set, add, start, create] reduces the chance of false matching.

Currently seems to be occurring for some Skill PR's in mycroft-skills eg MBTA Skill

krisgesling commented 4 years ago

There's another single keyword adapt intent in there, but it really needs to be converted to Padatious so will require some more consideration.

forslund commented 4 years ago

Works well, merging.