search

MycroftAI / skill-date-time

Mycroft AI official Date and Time Skill, providing the current time, date and day of week for cities around the world.
https://mycroft.ai/skills
Apache License 2.0
6 stars 56 forks source link

Make time UI responsive for vertical or horizontal screen orientation #92

Closed AIIX closed 3 years ago

AIIX commented 3 years ago

Make time ui responsive to vertical / horizontal screen orientation, fixes bug with time not scaling correctly on horizontal display due to previous fixed font values.

forslund commented 3 years ago

Works very well!

Not sure if the design has been discussed earlier but maybe we could add some padding on top and bottom to make it more similar to the previous version?

krisgesling commented 3 years ago

This looks much better, so will merge as is and can make further changes if desired.

@dschweppe can weigh in on the design aspect. I'm wondering if we only want the stacked design on portrait screens?

ie for landscape it would be:

1204

and portrait would retain the current:

12
04
dschweppe commented 3 years ago

Yes, I agree with @krisgesling the stacked design should be reserved for Portrait displays and for landscape we should do side by side.