updated examples section

MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant

GNU Lesser General Public License v3.0

114 stars 62 forks source link

updated examples section #102

Closed pfefferle closed 2 years ago

pfefferle commented 2 years ago

Description

Updated the examples section to represent the latest changes

Type of PR

[ ] Bugfix
[ ] Feature implementation
[ ] Refactor of code (without functional changes)
[X] Documentation improvements
[ ] Test improvements

stratus-ss commented 2 years ago

Thanks for the PR, can you explain why you are requesting these updates?

pfefferle commented 2 years ago

hey @stratus-ss if I remember correctly, we had comments in issues, that not every action in the examples section works, so I checked them and tried to update to the "new" and working versions and/or removed them:

"Read bedroom temperature" is no longer working
"Turn on the office light" does no longer support the "the"
"Turn on on the AC" had a typo and I am not sure if it still works

stratus-ss commented 2 years ago

Thanks for the reply. I appreciate the update. It just wasn't clear before.

I am going to merge this, assuming your testing is correct (my mark ii is currently out of commission)

pfefferle commented 2 years ago

I will try to be a bit more descriptive in the next PR.

Thanks for merging!