MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
114 stars 62 forks source link

Initial vacuum implementation #108

Closed pfefferle closed 1 month ago

pfefferle commented 2 years ago

How to use this template

You can try the implementation by saying: "start (the|) {Entity}"

Description

It refactors the code a bit, to have a more generic "start", "stop" and "pause" implementation.

If needed follow up with as much detail as required.

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR. Either delete those that do not apply, or add an x between the square brackets like so: - [x]

stratus-ss commented 1 year ago

Sorry for the delay in getting to this. We appreciate the PR!

We've been tied up for the past few months. I looked over this PR, haven't had time to actually test it. It would be ideal if we had tests to show before and after functionality still worked

Particularly because of the refactor. At first glance the refactor doesn't set off any immediate red flags, haven't been able to test yet

stratus-ss commented 1 year ago

If there is still interest in merging this, I'll need a volunteer to verify the PR. I'll leave this open until June then I am going to close it if there are no takers