CI: Freeze Mycroft core version

MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant

GNU Lesser General Public License v3.0

115 stars 62 forks source link

CI: Freeze Mycroft core version #109

Closed Tony763 closed 1 year ago

Tony763 commented 1 year ago

Description

Hi, this PR adds variable with Mycroft Core version to freeze it. This should stabilize CI environment as current Mycroft core dev branch seems to have problems with installation.

Type of PR

[x] Bugfix
[ ] Feature implementation
[ ] Refactor of code (without functional changes)
[ ] Documentation improvements
[ ] Test improvements

Tony763 commented 1 year ago

Hi @krisgesling, I know you have hands full with MK2 production, but this one should be fast to review.

PS: Hacktoberfest is here, so if accepted, add please a label.

Tony763 commented 1 year ago

Hi @krisgesling, could You please merge this?

stratus-ss commented 1 year ago

I think this is ok to merge, but I am not exactly clear what the implications of this are on the current process(es). @krisgesling is there something that needs to be updated elsewhere to take advantage of this change?

Tony763 commented 1 year ago

Hi @stratus-ss, this should have no big impact. This just freeze a version of Mycroft Core used in CI. Some last changes to Core did break it and all test done by CI in this repository were/are marked as fail as Core did not install at all.

After this change there is only one drawback, once in a while, somebody from you (or me) should check if Core did not change something major and update it's version. (Something similar you do in mycroft-skills repository).