MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
115 stars 62 forks source link

Fix issue #104 - Padatious intent and tracker list #112

Closed Tony763 closed 1 year ago

Tony763 commented 1 year ago

Description

PR contain workaround fixing #104 proposed by @zeronounours. Proper fix (new functions) is awaiting approve/merge of PR #3101.

As we want to update HA skill in Marketplace, it's better to use this workaround as proper fix can be incorporated later when PR is merged and new Mycroft Core is released.

Credit goes to @zeronounours. Thanks mate.

Fixes #64

Type of PR

Tony763 commented 1 year ago

Reported as working by @robertsawko here

stratus-ss commented 1 year ago

@Tony763 how do we test this?

Tony763 commented 1 year ago

Sadly, VK test did not catch this, as intent worked for it. Only hint about something be wrong was wrote into log and I missed it:

https://github.com/MycroftAI/skill-homeassistant/blob/6cd09655aec11d08f147e92d5f5dfbe2f77d774f/70/mycroft/skills.log#L333-L362

Tony763 commented 1 year ago

VK tests can be seen there: https://mycroftai.github.io/skill-homeassistant/70/

Tony763 commented 1 year ago

I will rebase this with latest merged commits, so CI can check this, tonight.

Tony763 commented 1 year ago

@stratus-ss or @krisgesling Could You add “Secure” label? I just rebased this PR to contain latest changes from 20.08 branch (CI should now work).

Tony763 commented 1 year ago

Rebased, CI run in my repo was successful.

Tony763 commented 1 year ago

Allure tests Ok, skill log OK, ready to go :rocket: