Closed Tony763 closed 1 year ago
@Tony763 how do we test this?
Sadly, VK test did not catch this, as intent worked for it. Only hint about something be wrong was wrote into log and I missed it:
VK tests can be seen there: https://mycroftai.github.io/skill-homeassistant/70/
I will rebase this with latest merged commits, so CI can check this, tonight.
@stratus-ss or @krisgesling Could You add “Secure” label? I just rebased this PR to contain latest changes from 20.08 branch (CI should now work).
Rebased, CI run in my repo was successful.
Allure tests Ok, skill log OK, ready to go :rocket:
Description
PR contain workaround fixing #104 proposed by @zeronounours. Proper fix (new functions) is awaiting approve/merge of PR #3101.
As we want to update HA skill in Marketplace, it's better to use this workaround as proper fix can be incorporated later when PR is merged and new Mycroft Core is released.
Credit goes to @zeronounours. Thanks mate.
Fixes #64
Type of PR