search

MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
114 stars 62 forks source link

"Install" command installs out-of-date Git files #30

Closed tycrek closed 4 years ago

tycrek commented 4 years ago

When using the voice command to install home assistant, it incorrectly installs the version with YAML settings. Doing a git pull in the homeassistant skills directory updates to the correct version, at which point the Skill can be configured at home.mycroft.ai.

Please fix the skill installation so it uses the JSON settings file instead of the broken YAML file. There is zero documentation for this, so hopefully this issue helps someone else.

forslund commented 4 years ago

The skill was updated just on Friday and hasn't been submitted to the Marketplace, we were pending a decision if the skill should be modified or if the backend should be fixed to handle the failing value. (both versions actually uses the yaml, just corrected syntax)

forslund commented 4 years ago

@tycrek The version in the marketplace has been updated. @krisgesling ended up reverting a couple of changes in the settingsmeta yaml file to match the old json (to hinder the backend from wiping the settings). Since you did an update to the previous half-finished state your settings may disappear from mycroft-home.)

tycrek commented 4 years ago

Ok, thanks for letting me know :)

Josh Moore Software Developer Visit my website https://jmoore.dev/ or check out my GitHub https://github.com/tycrek/

Mar. 2, 2020, 7:26 a.m. by notifications@github.com:

@tycrek https://github.com/tycrek> The version in the marketplace has been updated. > @krisgesling https://github.com/krisgesling> ended up reverting a couple of changes in the settingsmeta yaml file to match the old json (to hinder the backend from wiping the settings). Since you did an update to the previous half-finished state your settings may disappear from mycroft-home.)

— You are receiving this because you were mentioned. Reply to this email directly, > view it on GitHub https://github.com/MycroftAI/mycroft-homeassistant/issues/30?email_source=notifications&email_token=AHEKGABTDMMBTBC4HJZ4X4TRFO625A5CNFSM4K7NILN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENPP5PY#issuecomment-593428159> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AHEKGAGINMISTSDX32KTHTLRFO625ANCNFSM4K7NILNQ> .