MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
114 stars 62 forks source link

process for new vocab - scene via "Hey Mycroft, it's <scene name>" #34

Closed fermulator closed 2 years ago

fermulator commented 4 years ago

Hello! This issue is more of a question to start, but based on answers I'd like to submit a PR.

As per https://github.com/MycroftAI/mycroft-homeassistant/blob/20.02/vocab/en-us/AutomationActionKeyword.voc, we have some initial great vocab for activating scenes/automation in home assistant.

We have some scenes like:

So we can activate them with:

So! To make it slightly more intuitive, we are thinking it would be +1 cool factor to just say:

So, questions:

  1. is there a process for this project to extend vocab?
  2. are there potential for conflicts with generic mycroft vocab? (i.e. in this case "it's" is arguably a generic word...)

thx!

Tony763 commented 4 years ago
  1. Simple PR.
  2. HA skill use higher priority for fall back. So it should test intens as first, if it not find wanted scene, it will fallback to another skill. EDIT: Will not fallback, but say it did not find entity.
        # Needs higher priority than general fallback skills   
        self.register_fallback(self.handle_fallback, 2)

    I would try use it as "Hey Mycroft, it's 'scene', now." --> ex "Hey Mycroft, it's Movie Time, now"

With scene named Movie: image HA needs at least 50 % match - it mabye should be higher.

    # require a score above 50%   
      best_score = 50

image image

stratus-ss commented 2 years ago

i'm closing this because it appears to be stale. Please reopen if it is still an issue