MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
114 stars 62 forks source link

Allow for fuzzy top/bottom brightness and adjust speech percentage #41

Closed Fmstrat closed 4 years ago

Fmstrat commented 4 years ago

Description:

Currently the system does not allow for adjusting percentage brightness above 100% or below 0%. This allows users to speak in fuzzy terms, I.E. if the brightness is at 80% and a user asks to increase brightness by 30%, it will jump to 100% vs erroring. Also, the response from MyCroft was using brightness levels of 0-255 vs 0-100%. This was adjusted as well.

Checklist:

(Note: I believe the PR needs to start to know about tests)

Fmstrat commented 4 years ago

Sounds good, happy to amend the commit to do what is described.

Fmstrat commented 4 years ago

@stratus-ss Commit has been amended, let me know what you think!