search

MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
114 stars 62 forks source link

Feature: Entity availability check #52

Closed Tony763 closed 3 years ago

Tony763 commented 3 years ago

Description:

Checklist:

stratus-ss commented 3 years ago

@Tony763 this one has a merge conflict. It's an easy fix

Tony763 commented 3 years ago

Fixed

Tony763 commented 3 years ago

@stratus-ss when will you have a time, check this one first so I can continue with next PRs.

stratus-ss commented 3 years ago

This one LGTM but needs to pend until I can test it.

I don't see a problem in the code, it makes logical sense. I just need to set aside some time to test this. Probably next week

Tony763 commented 3 years ago

Ok, I will wait with next batch of PRs.

stratus-ss commented 3 years ago

Haven't forgotten about this one. Just havent had time to test it yet

renekliment commented 3 years ago

Hi! Is there anything that can be done for example by the community to push this forward? Are there test cases that we could try and report back? Thanks!

stratus-ss commented 3 years ago

Hi! Is there anything that can be done for example by the community to push this forward? Are there test cases that we could try and report back? Thanks!

Tests are always helpful! As are exact examples of how one might test a specific PR.

i.e. when you run the following commands, you should expect the following output

stratus-ss commented 3 years ago

I had to adjust the following lines

-from mycroft import MycroftSkill, intent_file_handler
+from mycroft import MycroftSkill, intent_file_handler, intent_handler
-       """ Return result to underliing function. """
+            """ Return result to underliing function. """
Tony763 commented 3 years ago

@stratus-ss: Sorry, stupid copy paste error. Resolved. Let me know if it is ok, I will rebase changes.