Issue #63: STT engine return percentage as symbol

MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant

GNU Lesser General Public License v3.0

114 stars 62 forks source link

Issue #63: STT engine return percentage as symbol #68

Closed Tony763 closed 3 years ago

Tony763 commented 3 years ago

Description

fix issue #63 - intent to set light brightness percentage, STT return percentage as symbol Updated all languages

Type of PR

[x] Bugfix
[ ] Feature implementation
[ ] Refactor of code (without functional changes)
[ ] Documentation improvements
[ ] Test improvements

stratus-ss commented 3 years ago

LGTM although pending testing. Hopefully I can get to this tonight, although I don't forsee any problems

stratus-ss commented 3 years ago

i'll put some effort around this this week. Sorry for the delay

stratus-ss commented 3 years ago

@Tony763 the tests are failing. This change requires a change to

/opt/mycroft/skills/homeassistant.mycroftai/test/intent/016.SetLightBrightUnknown.intent.json
/opt/mycroft/skills/homeassistant.mycroftai/test/intent/006.SetLightBright.intent.json

When I edited these the tests pass and I can confirm the the light still changes

Please make the changes to the tests and I will merge this

Tony763 commented 3 years ago

Hi @stratus-ss sorry for the delay, I missed notification. Old tests fixed. VK tests will be added in tests refactor.

krisgesling commented 3 years ago

Hey Tony, can you check these conflicts from the last PR getting merged? Seems like this one is good to go otherwise

Tony763 commented 3 years ago

Hi @krisgesling , conflicts solved, ready to go.