remove optional `thermostat` keyword

[pfefferle]

Description

Remove optional thermostat keyword from sensor.intent to:

• have a consistent wording
  • was not part of all translations
  • it was the only existant sensor, that was directly named
• a lot of people do prefix their thermostats like "thermostat kitchen", in this case you have to use "the value of thermostat thermostat kitchen"

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR. Either delete those that do not apply, or add an x between the square brackets like so: - [x]

• [X] Bugfix
• [ ] Feature implementation
• [ ] Refactor of code (without functional changes)
• [ ] Documentation improvements
• [ ] Test improvements

[pfefferle]

@krisgesling can you check this PR please.

[krisgesling]

Hmmm, I don't use thermostats at all - @stratus-ss do you use this?

"thermostat" seems like a very North American thing - we just have our tropical geographic temp set to 32 degrees all year round :laughing:

At the very least it seems like a strange way to phrase it. I would say:

What is the value of the kitchen thermostat What is the value of the thermostat in the kitchen

Not:

What is the value of the thermostat kitchen

[pfefferle]

I agree with your examples, but the phrase seems to be as generic as possible, so that you can ask for the status of lights, thermostats, binary_sensors, covers, ... in the same way.

I would vote for keeping it like it is for now (and remove thermostat to be consistant) and maybe work on more specific phrases for the different sensors in a separate PR.

[stratus-ss]

I don't use this specific function, however thermostat is a common thing in these parts.

I don't have any objection to making this more generic.

FWIW, I am more likely to say "what is the temperature set to" or "what is the temperature in the house".

I might ask what the state of the thermostat is if I wanted to know if it was off, set to air conditioning or heating

[pfefferle]

FWIW, I am more likely to say "what is the temperature set to" or "what is the temperature in the house".

I agree, but this is a whole new feature/usecase, for this we need to check groups and areas (kitchen or first floor instead of {name of thermostat}) (#76) and not specific thermostats and/or other sensors.

[pfefferle]

what about removing the thermostat, but adding some more question possibilities like:

what is the temperature of {Entity}

[pfefferle]

@krisgesling @stratus-ss I added some attributes as alternative to state, what do you think?

[stratus-ss]

What is the position key word for?

[pfefferle]

good point, it is for trackers, but there is no support yet, so I removed it.