MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
115 stars 62 forks source link

Normalize IP address setting #79

Closed krisgesling closed 1 year ago

krisgesling commented 2 years ago

Is your feature request related to a problem? Please describe. An issue I've seen reported many times over the years is that people enter their host / ip address settings in different ways and it's not clear which format should be used. For example you might enter:

Describe the solution you'd like Ideally we would accept any logical format and normalize these to what the Home Assistant client expects.

Describe alternatives you've considered Alternatively we can improve the documentation about what is required, but as much as I love documentation, I also know that most people don't read it.

Tony763 commented 2 years ago

Ok, will check.

krisgesling commented 2 years ago

Not an essential thing, just something I've noticed and thought it might make a good Hacktoberfest project for someone - but feel free to take it on yourself too :)

Tony763 commented 2 years ago

'ha_client.py' expect pure IP or domain name so it should by doable with some small regex.

BTW: It's 7. and I still do not have my 4 accepted commits :)

krisgesling commented 2 years ago

ooh they're increasing the requirements this year!

It's so wildly different - you get lots of people trying to submit single letter typo fixes, and others writing an entire Skill for a single PR.

pfefferle commented 2 years ago

Can this be closed?

Tony763 commented 1 year ago

Hi @krisgesling, could You close this as it's merged.