search

MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
115 stars 62 forks source link

Add function to list tracker entities and register them. #89

Closed Tony763 closed 2 years ago

Tony763 commented 2 years ago

Description

Added function to get list of tracker entities at connection to HA. List is saved as tracker.entity in vocab folder and registered by register_entity_file()

Padatious intent for tracker then react only for them.

Should solve conflict with skill where aka #64 .

Type of PR

Testing

Added test vk test where skill should not react.

Tony763 commented 2 years ago

Hi @krisgesling , PR rebased with latest changes. Could you start tests?

Tony763 commented 2 years ago

Hi Kris, tests added and passing. Allure report

Tony763 commented 2 years ago

Wow, change in workflow correctly detected :slightly_smiling_face:

Tony763 commented 2 years ago

Fixed some weird merge issues, houp I did not break anything.

@krisgesling could You check changes, please? Also change in workflow is necessary.

krisgesling commented 2 years ago

This I believe will fix the installation issue: https://github.com/MycroftAI/mycroft-core/pull/3048

Tony763 commented 2 years ago

Fix for action is in this PR. Check change in workflow file and action run in my repo.

Tony763 commented 2 years ago

Ou, I just opened an allure report and there is something wrong, I will recheck it tonight.

Tony763 commented 2 years ago

@krisgesling fixed, should be ready to go :slightly_smiling_face:

Tony763 commented 2 years ago

Hi @krisgesling , tests will fail until the fix for workflow in this PR is merged. Should I send it as different PR?

Tony763 commented 2 years ago

bump @krisgesling

krisgesling commented 2 years ago

Sorry Tony, was out for a few months and its taken a while to catch up on things.

The overall test run seems to be failing on dev_setup. I'm doing a fix in core that might solve that.

It would be better if we did the workflow changes in a new PR - just easier to track what's happening

Tony763 commented 2 years ago

Hi @krisgesling, hope You are okay :slightly_smiling_face: I rebased PR with latest changes merged into 20.08. Every thing seems to work again so feel free to add secure label to start tests.

krisgesling commented 2 years ago

Great, thanks :)

I'm doing well - had our second baby and then some covid thrown in for good measure :dizzy_face: but come out the other side and slowly getting back on top of all our repo's!

krisgesling commented 2 years ago

WOOOOH :rocket:

Tony763 commented 2 years ago

Great, thanks :)

I'm doing well - had our second baby and then some covid thrown in for good measure dizzy_face but come out the other side and slowly getting back on top of all our repo's!

Then congratulation :tada:. Yeah, covid is spreading there too, I got it two weeks ago. Thankfully, vaccination worked so I managed it with just light cold. Just long stairs are now enemy number one, but it gets better each day.