search

MycroftAI / skill-homeassistant

Mycroft Skill/Integration for Homeassistant
GNU Lesser General Public License v3.0
114 stars 62 forks source link

Corrected French imperative verbs #99

Closed guillaumenibert closed 2 years ago

guillaumenibert commented 2 years ago

Description

fixes #98 STT from Google understands imperative verbs when language is set to French language. However, some verbs are not in the correct French imperative form. These verbs are located in the files stored in vocab/fr-fr directory.

Type of PR

Testing

Speak in French to Mycroft.

krisgesling commented 2 years ago

Hey there, thanks for signing the CLA and helping out with the project.

Is it worth having both versions, eg (Définis|Défini)? Or are your changes only replacing completely incorrect forms? i.e. are there any regional or personal differences, slang forms, etc?

Tony763 commented 2 years ago

Also I will check which voc files are neccesary, I think, I did not make a clean up when we merged padatious intenst.

guillaumenibert commented 2 years ago

Hello, I only changed the incorrect forms for the imperative.

"défini" exists in other tenses that are past. It would be strange to speak in the past tense to Mycroft.

If you say "défini la température à 15°C" , which is incorrect in French, STT will understand "définis la température à 15°C" (set the temperature at 15 ° C); as the verb "définis" is not in the vocab/fr-fr database. Mycroft will return that he doesn't understand. STT will in no case be able to transcribe "défini" if you speak in imperative.

It is very subtle, because when spoken, there is no difference in pronunciation between "défini" and "définis". This is why STT only understands the correct form, ie "définis" in the imperative tense.

That's why I don't think it's interesting to have both "défini" and "définis".

There are no regional differences with regard to grammar (apart from perhaps very rare exceptions, which do not concern the verbs of the vocab).

There may be other action verbs in other countries where French is spoken, but these are other codes (fr-be) for Belgium, (fr-ca) for French Canadian... And I don't know them.

Tony763 commented 2 years ago

These voc files ar not used anymore, I will prepare a clean up in evening tomorrow. image

krisgesling commented 2 years ago

We'll also want to get this updated in translate.mycroft.ai but that would be extremely out of date for this Skill at the moment. So I'd hold off until this gets updated in the Marketplace.