MycroftAI / skill-joke

Mycroft AI official Joke Skill - provide basic jokes
https://mycroft.ai/skills
Apache License 2.0
7 stars 20 forks source link

Translations for non-supported languages #18

Open mikewoudenberg opened 4 years ago

mikewoudenberg commented 4 years ago

I'm running a mycorft instance in Dutch (nl-nl) mode, and I am able to trigger this skill by asking Mycroft to vertel een grap. This triggers an error in the execution in the Joking Skill because pyjokes doesn't support the dutch locale.

What is the point in adding translations when the skill cannot handle the requests in the translated language?

forslund commented 4 years ago

Thanks for reporting, I guess it's not all that useful. Translating a skill to a language does not only entail translating the intents and dialogs, it can mean adding extra resources for that language or help translate an upstream project.

We'd like to support many languages so in this case we really rely on the help from the community. You can do a couple of things to help out:

What we definitely should do is to try to fallback to English if a language isn't supported.