MycroftAI / skill-joke

Mycroft AI official Joke Skill - provide basic jokes

https://mycroft.ai/skills

Apache License 2.0

7 stars 20 forks source link

Changes for Basque language #28

Closed e-gor closed 2 years ago

e-gor commented 3 years ago

Changes for Basque language

Description

These changes, along with those sent to other repos, make Mycroft work in Basque language.

Made by Elhuyar, Talaios and Skura

Type of PR

Feature implementation

krisgesling commented 2 years ago

Hey Igor, I'm hesitant for us to start hosting jokes. What is funny or appropriate can be a huge debate that I'd just rather not get into right now. No idea what these jokes are about, they could be completely harmless - it's just the precedent that it sets.

Given it's quite a simple Skill would you be happy to create a separate Basque Jokes Skill?

e-gor commented 2 years ago

OK, yes, we will. Will you just reject the PR or do I have to remove it or something? Thanks very much!