fix play fails if settings fetch fails; and refactor

MycroftAI / skill-npr-news

Mycroft AI official News Skill, providing the latest news report from your favorite broadcast.

https://mycroft.ai/skills

Apache License 2.0

9 stars 42 forks source link

Closed krisgesling closed 5 years ago

krisgesling commented 5 years ago

Fix issue where news fails to play if settings are not retrieved correctly.
Minor refactor and change get_rss() to get_station() for clarity now that direct download urls are supported.
Sanitize url passed to curl to prevent remote code execution from malicious rss feed - thanks to Ignacio Dominguez for highlighting this.

forslund commented 5 years ago

Looks good, I did another change so curl is run without shell=True and some cleanup.

Also please separate multiple changes like this into different commits. It greatly helps when doing a review.

Anyway, merging.