search

MycroftAI / skill-npr-news

Mycroft AI official News Skill, providing the latest news report from your favorite broadcast.
https://mycroft.ai/skills
Apache License 2.0
9 stars 42 forks source link

Fix #75: non-default stations not matching #77

Closed krisgesling closed 4 years ago

krisgesling commented 4 years ago

Fix #75

Had a quick look, it's not matching with high enough confidence so returns the default station.

Tidied up a little more, and it's passing VK and the old test runner. "Play the BBC News" is already included as a test phrase, however it's currently only testing that the Skill handles it. We'll need to go deeper to ensure the right feed is extracted and returned.

krisgesling commented 4 years ago

I've also added another Step to the specific station tests to check that the right station is selected. The searching now exclude's "the" from the phrase as this was returning too high a confidence for "other". Also added a search of the long name from the FEEDS dict which didn't exist before. This meant that a phrase like "ABC News Australia" would return a lower confidence than simply "ABC".

forslund commented 4 years ago

It's much better :+1: but it doesn't quite cover the failing case in #75. I've added tests for a couple of these failing utterances.

Since this is much better I'm going to merge it but let #75 stay open.