search

MycroftAI / skill-npr-news

Mycroft AI official News Skill, providing the latest news report from your favorite broadcast.
https://mycroft.ai/skills
Apache License 2.0
9 stars 42 forks source link

Fix Step vocab conflict and low confidence matching #82

Closed krisgesling closed 4 years ago

krisgesling commented 4 years ago

Modified the Skill based Step vocab to avoid conflicts with same step that is in the process of being included in mycroft-core. Once it has been moved to a production release we can remove this workaround and restore the existing language.

Also stopped returning any data on low-confidence (<0.5) CPS matches. Turns out that returning a match level of None, will still play the data returned if nothing else can play. So on systems where no other CPS's are present, then the news will play something and the test fails.

Thanks to Ake for the debugging here.

krisgesling commented 4 years ago

Minor update and tests passing, self merging.