search

MycroftAI / skill-pairing

Mycroft AI official Pairing Skill - connect your Device to home.mycroft.ai
https://mycroft.ai/skills
Apache License 2.0
5 stars 32 forks source link

Skill always report ready after pairing #59

Open j1nx opened 4 years ago

j1nx commented 4 years ago

If I correctly understand the code, after the pairing process the skill should check if Mycroft is fully ready and if;

Not ready: Should speak "wait.for.startup.dialog" Ready: Should speak "pairing.paired.dialog"

However the skill ALWAYS speaks the "pairing.paired.dialog" despite mycroft still downloading and installing skills in the background. Probably related to; https://github.com/MycroftAI/mycroft-core/pull/2642

krisgesling commented 4 years ago

Hey j1nx, thanks for linking these up.

From my poking around, I believe this Skill is working as it should, as it's receiving the mycroft.ready message before it speaks "pairing.paired". So from this Skills perspective it's been told that Mycroft is ready to roll.

This message is currently emitted from the Padatious service, so in effect indicates that the first round of intent training has been completed. Which may be only the priority loaded Skills - volume and pairing. However as you've seen this does not necessarily mean that "Mycroft is completely ready".

There is a bit more discussion in mycroft-core issue #2639 about what mycroft.ready should really mean eg do we include Skill updates or just train the versions of the Skills on the device? Be good to get your thoughts there.