search

MycroftAI / skill-pandora

Mycroft AI official Pandora Skill - listen to Pandora music
https://mycroft.ai/skills
MIT License
6 stars 12 forks source link

Allow skipping while paused #29

Open pixelherodev opened 5 years ago

pixelherodev commented 5 years ago

There's really no reason it should have to be playing to skip, especially because the state is set to autopause when you say the wake word! As is, saying "skip song" is nearly useless because it's never in the playing state, and either way you shouldn't have to do two separate commands (WAKE WORD, resume; WAKE WORD, next song).

krisgesling commented 4 years ago

Hey there, I just saw this PR when following up on your CLA. Sorry it didn't get looked it last year!

Still seems to be relevant and not sure why it would need to be in a playing state.

Unfortunately as Pandora is US only it's a pain to test these so I'll post in the community. If anyone else can validate this works as expected I'm happy to merge it in.

pixelherodev commented 4 years ago

I can't even test this anymore, as I haven't been able to get Mycroft working locally again.

pixelherodev commented 1 year ago

Given that someone else has apparently merged this on their branch, is that good enough to indicate that this is tested? :P If not, I'm just going to close this. I don't use Mycroft anymore, and I'm not going to build it to test a change I no longer care about, sorry :/

mikejgray commented 9 months ago

Given that someone else has apparently merged this on their branch, is that good enough to indicate that this is tested? :P If not, I'm just going to close this. I don't use Mycroft anymore, and I'm not going to build it to test a change I no longer care about, sorry :/

Just saw this - yes, I merged and tested it, and it seemed to work. I've been off Picroft for a while now and using OVOS/Neon.AI, which are maintained forks of Mycroft. I'm looking at it again as it's now possible to disable a feature that made these classic Mycroft media skills useless.