Removing the extra space is a correct fix and we're thankful. We do however wish to keep the { on the same line. (This is part of the code style we adhere to) If you could revert that change and sign our CLA (https://mycroft.ai/cla/) I'd be happy to merge this.
For future contributions I'd recommend you stick to the following:
Use a good commit message "Make change" doesn't tell me anything, write something like "Fix typo and curly brace"
Secondly Split different changes into separate commits. Changing the coding style is different from fixing typos and to make my reviewing easier it'd be better with two separate commits:
Commit 1: Change function coding style
Commit 2: Update comments and fix typo
I have a sneaking suspicion this is a Hacktoberfest related PR, but we all have to start somewhere. I hope you read this and maybe learn something.
Removing the extra space is a correct fix and we're thankful. We do however wish to keep the
{
on the same line. (This is part of the code style we adhere to) If you could revert that change and sign our CLA (https://mycroft.ai/cla/) I'd be happy to merge this.For future contributions I'd recommend you stick to the following:
I have a sneaking suspicion this is a Hacktoberfest related PR, but we all have to start somewhere. I hope you read this and maybe learn something.
Hope to see you around the project more!