MycroftAI / skill-reminder

Mycroft AI official Reminder Skill - set reminders
https://mycroft.ai/skills
Apache License 2.0
14 stars 28 forks source link

Intent not triggered or not correctly triggered with form "remind me at" #2

Open jrwarwick opened 6 years ago

jrwarwick commented 6 years ago

Three utterances that did not work as expected: "remind me tonight at 5:30 p.m. to pick up the kids" -15 hours off another time ( failed to find date/time once, too even though the recognized utterance was the same) "remind me at 5:30 p.m. tonight to pick up the kids" - found date time, but incorrect, 15 hours off "remind me to perform pick up at 7" - not possible to set a reminder for the informed date and time

Log excerpt at pastebin: https://privatebin.net/?2c2dd8a00dd378fe#np8XBp2J8a8wBtNfHHZYwu6aSSmzKta3g0Yv8SYy/5s=

jrwarwick commented 6 years ago

Another minor variation that did not work:


21:25:35.650 - SKILLS - DEBUG - {"type": "skill.converse.request", "data": {"lang": "en-US", "skill_id": 2021541921, "utterances": ["set a reminder for 4 p.m. today to head home"]}, "context": null}
21:25:35.661 - SKILLS - DEBUG - {"type": "skill.converse.response", "data": {"skill_id": 2021541921, "result": false}, "context": null}
21:25:35.623 - mycroft.client.speech.listener:transcribe:166 - DEBUG - STT: set a reminder for 4 p.m. today to head home
21:25:35.626 - mycroft.client.speech.main:handle_utterance:62 - INFO - Utterance: [u'set a reminder for 4 p.m. today to head home']
21:25:35.632 - requests.packages.urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): api.mycroft.ai
21:25:35.800 - mycroft.skills.intent_service:send_metrics:244 - DEBUG - Sending metric
21:25:35.808 - requests.packages.urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): api.mycroft.ai
~~~~ a reminder for 4 p.m. today to head home", "CACBFEBJCBReminderSkillCreateVerb": "set reminder"}, "context": {"client_name": "mycroft_listener", "ident": "1522099533.39-670776464", "target": null}}
21:25:35.830 - SKILLS - DEBUG - {"type": "mycroft.skill.handler.start", "data": {"name": "ReminderSkill.handle_create"}, "context": null}
21:25:35.835 - requests.packages.urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): api.mycroft.ai
~~~~pect_response": false, "utterance": "Sorry, I didn't find a valid date and time to remind you."}, "context": {"client_name": "mycroft_listener", "ident": "1522099533.39-670776464", "target": null}}
21:25:35.871 - SKILLS - DEBUG - {"type": "mycroft.skill.handler.complete", "data": {"name": "ReminderSkill.handle_create"}, "context": null}
jrwarwick commented 6 years ago

A couple more specific speech cases:

set a reminder today at 10 o'clock

and

remind me at 10 a.m. to set another reminder


16:00:06.445 - SKILLS - DEBUG - {"context": null, "data": {"utterances": ["set a reminder today at 10"], "lang": "en-US", "skill_id": "skill-reminder"}, "type": "skill.converse.request"}
16:00:06.458 - SKILLS - DEBUG - {"context": {}, "data": {"skill_id": "skill-reminder", "result": false}, "type": "skill.converse.response"}
~~~~eminder", "data": [["set reminder", "skill_reminderReminderSkillCreateVerb"]], "key": "set reminder"}], "confidence": 1.0, "end_token": 1}], "confidence": 0.5, "target": null}, "type": "skill-reminder:ReminderSkillCreateIntent"}
16:00:06.576 - mycroft.skills.intent_service:send_metrics:241 - DEBUG - Sending metric if opt_in is enabled
16:00:06.584 - SKILLS - DEBUG - {"context": {"client_name": "mycroft_listener", "ident": "1528300804.540321-1880215544", "target": null}, "data": {"name": "ReminderSkill.handle_create"}, "type": "mycroft.skill.handler.start"}
~~~~ient_name": "mycroft_listener", "ident": "1528300804.540321-1880215544", "target": null}, "data": {"utterance": "It was not possible to set a reminder for the informed date and time.", "expect_response": false}, "type": "speak"}
16:00:06.629 - SKILLS - DEBUG - {"context": {"client_name": "mycroft_listener", "ident": "1528300804.540321-1880215544", "target": null}, "data": {"name": "ReminderSkill.handle_create"}, "type": "mycroft.skill.handler.complete"}
16:00:06.631 - SKILLS - DEBUG - {"type": "recognizer_loop:audio_output_start", "data": {}, "context": null}

16:05:38.724 - SKILLS - DEBUG - {"context": null, "data": {"utterances": ["remind me at 10 a.m. to set another reminder"], "lang": "en-US", "skill_id": "skill-reminder"}, "type": "skill.converse.request"}
16:05:38.735 - SKILLS - DEBUG - {"context": {}, "data": {"skill_id": "skill-reminder", "result": false}, "type": "skill.converse.response"}
16:05:38.869 - mycroft.skills.intent_service:send_metrics:241 - DEBUG - Sending metric if opt_in is enabled
~~~~ "data": [["remind me", "skill_reminderReminderSkillCreateVerb"]], "key": "remind me"}], "confidence": 1.0, "end_token": 1}], "confidence": 0.3333333333333333, "target": null}, "type": "skill-reminder:ReminderSkillCreateIntent"}
16:05:38.896 - SKILLS - DEBUG - {"context": {"client_name": "mycroft_listener", "ident": "1528301136.5274777-1924666918", "target": null}, "data": {"name": "ReminderSkill.handle_create"}, "type": "mycroft.skill.handler.start"}
~~~~ent_name": "mycroft_listener", "ident": "1528301136.5274777-1924666918", "target": null}, "data": {"utterance": "It was not possible to set a reminder for the informed date and time.", "expect_response": false}, "type": "speak"}
jrwarwick commented 5 years ago

Here is another, similar form that I found does not work: I said this: " set a reminder for tomorrow morning " And then got this: " >> I don't understand, but I'm learning new things everyday. " Instead of what I expected: "setting a reminder for tomorrow morning at 8:00, what shall I remind you of?" (begins listening again). Perhaps this would best be listed as a separate issue since it involves multiple rounds of dialogue.

jrwarwick commented 2 years ago

On a mark II (core v21.02), here are a few utterances that failed to trigger intent, but should have (along with the unexpected dialog response): (Utterance): in one hour remind me to check in on the lumen contractor (Dialog): >> This article lists direct English translations of common Latin phrases. Some of the phrases are themselves translations of Greek phrases, as Greek rhetoric and literature
reached its peak centuries before that of ancient Rome.

(Utterance): set a reminder for 1 hour from now (Dialog): >> Repetitive strain injuries are to the body's muscles, joints, tendons, ligaments, bones,
or nerves caused by repetitive movements. Such injuries are more likely if the movements required force or were accompanied by vibrations, compression, or the maintenance of
sustained or awkward positions.

(Utterance): please set a reminder
(Dialog): >> The Matrix is an American media franchise consisting of four feature films, beginning
with The Matrix and continuing with three sequels, The Matrix Reloaded, The Matrix
Revolutions, and The Matrix Resurrections .

krisgesling commented 2 years ago

Thanks for these - this Skill needs a solid review so we'll get these added as integration test utterances.

The responses you're seeing a from the Common Query Framework, but shows they weren't picked up by the Reminder Skill when they should have been. We've also been making some improvements to the CQF so it doesn't try to answer every utterance.