no more hard coded mp3 - Githubissues

MycroftAI / skill-singing

Mycroft AI official Singing Skill - Mycroft speaks lyrics to popular songs

https://mycroft.ai/skills

Apache License 2.0

14 stars 19 forks source link

Closed denics closed 4 years ago

denics commented 4 years ago

This solve #27 TODO: make "mypath" customizable

denics commented 4 years ago

Improved Italian dialogs and modernized en vocab

krisgesling commented 4 years ago

Hi Denics,

This feels like a different Skill rather than an update. Have you thought about forking it and submitting it as a new, independent Skill?

You would just need to find some unique vocab to trigger it like:

"sing my favourite song" "sing my local songs"

If you wanted to use the term "play", eg "play my favourite song", then you'd need to look at the Common Play Framework.

denics commented 4 years ago

I understand, I will do my own skill then. Thanks