Improve check for is singing

MycroftAI / skill-singing

Mycroft AI official Singing Skill - Mycroft speaks lyrics to popular songs

https://mycroft.ai/skills

Apache License 2.0

14 stars 19 forks source link

Improve check for is singing #34

Closed forslund closed 3 years ago

forslund commented 3 years ago

Description

This is an attempt to get the skill tester to work more consistently with the singing skill. This changes to use the same check as in npr-news verifying that audioservice play is sent instead of waiting for dialog.

Type of PR

[ ] Bugfix
[ ] Feature implementation
[ ] Refactor of code (without functional changes)
[ ] Documentation improvements
[ x ] Test improvements

Testing

Test in VK to see that the tests still pass.

krisgesling commented 3 years ago

:facepalm: going through my inbox at the moment - I should have known you would have added this

krisgesling commented 3 years ago

what do you think about the rename and adding it to core?

krisgesling commented 3 years ago

Closing in favor of #35