search

MycroftAI / skill-stock

Mycroft AI official Stock Skill - providing current prices of stocks
https://mycroft.ai/skills
Apache License 2.0
7 stars 18 forks source link

Can another api be used? #36

Open semiexperienced opened 2 years ago

semiexperienced commented 2 years ago

There are other api's available, I believe yahoo finance api does not require an api key

https://medium.com/harinathselvaraj/python-code-to-get-realtime-stock-prices-from-yahoo-finance-66d7d1858133

krisgesling commented 2 years ago

Hey there,

I remember looking at Yahoo finance. From my notes it seemed open, though I couldn't find any official documentation for it. Some posts claim a rate limit of 500 per day, others 2000 per hour shrug

I think we're better off switching to paid and sustainable service, so if anyone is keen to get it going, we can get a paid API key setup to let you develop against, or if anyone wants to add the Yahoo finance API as an option, we'll happily accept a PR for that too.

For the moment, we've decided to de-prioritize this Skill, and its status as a default Skill has been removed from devices.

semiexperienced commented 2 years ago

Hey there,

I remember looking at Yahoo finance. From my notes it seemed open, though I couldn't find any official documentation for it. Some posts claim a rate limit of 500 per day, others 2000 per hour shrug

I think we're better off switching to paid and sustainable service, so if anyone is keen to get it going, we can get a paid API key setup to let you develop against, or if anyone wants to add the Yahoo finance API as an option, we'll happily accept a PR for that too.

For the moment, we've decided to de-prioritize this Skill, and its status as a default Skill has been removed from devices.

IS there documentation for this skill? I will try for the yahoo finance

semiexperienced commented 2 years ago

Hey there,

I remember looking at Yahoo finance. From my notes it seemed open, though I couldn't find any official documentation for it. Some posts claim a rate limit of 500 per day, others 2000 per hour shrug

I think we're better off switching to paid and sustainable service, so if anyone is keen to get it going, we can get a paid API key setup to let you develop against, or if anyone wants to add the Yahoo finance API as an option, we'll happily accept a PR for that too.

For the moment, we've decided to de-prioritize this Skill, and its status as a default Skill has been removed from devices. Here is yfinance, a python package for yahoo finance. could be easier than the api https://pypi.org/project/yfinance/

krisgesling commented 2 years ago

Hey good find, though taking a quick look at that package info highlights a problem...

You should refer to Yahoo!'s terms of use (here, here, and here) for details on your rights to use the actual data downloaded. Remember - the Yahoo! finance API is intended for personal use only.

With that in mind, I'd say that anyone is more than welcome to do a fork of the Stock Skill with yfinance, however it's not something we'd be able to package up as a default for all Mycroft users as it's for personal use only.

For the project as a whole, it's better for us to develop against a stable paid API, but for individuals I can certainly see the appeal of using free services when you only want to do a few queries each month.