Feature/update

[forslund]

Fixes issue with not returning any answer

• switches to json instead of XML
• update the skill
• update license

[KathyReid]

Pull in this PR for testing

pi@mark_1:~/skills/mycroft-stock.mycroftai $ sudo -u mycroft git checkout feature/update
Branch feature/update set up to track remote branch feature/update from origin.
Switched to a new branch 'feature/update'
pi@mark_1:~/skills/mycroft-stock.mycroftai $ sudo -u mycroft git pull
Already up-to-date.
pi@mark_1:~/skills/mycroft-stock.mycroftai $ sudo -u mycroft git pull origin feature/update
From https://github.com/mycroftai/skill-stock
 * branch            feature/update -> FETCH_HEAD
Already up-to-date.

Test utterances

• Hey Mycroft, stock price of Google

  "With ticker symbol VXGOG, the current price of CBOE Google VIX Index is 0 dollars per share"

figured Google was not Google but Alphabet, derp!

• Hey Mycroft, stock price of Alphabet

  "Alphabet Inc, with ticker symbol GOOGL is currently trading at 1116.28 dollars per share."

• Hey Mycroft, stock price of Apple

  "Apple Inc, with ticker symbol AAPL is currently trading at 183.92 dollars per share."

• Hey Mycroft, stock price of Microsoft

  "Microsoft Corp, with ticker symbol MSFT is currently trading at 99.05 dollars per share."

• Hey Mycroft, stock price of Atlassian

  "Atlassian Corp PLC, with ticker symbol TEAM is currently trading at 62.98 dollars per share."

• Hey Mycroft, stock price of Walmart

  "With ticker symbol WMT, the current price of Walmart Inc is 84.79 dollars per share."

• Hey Mycroft, stock price of Bloomberg

  "With ticker symbol WMT, the current price of Walmart Inc is 84.79 dollars per share."

• Hey Mycroft, stock price of General Electric

  "With ticker symbol GE, the current price of General Electric Co is 13.37 dollars per share."

---

• Hey Mycroft, stock price for petroleo brasileiro

  "Sorry I don't understand" <-- I tried several permutations of this, but it just couldn't understand this stock name, no matter what I tried. Probably an edge case somewhere.

• Hey Mycroft, stock price for Alcoa

  "I'm not sure I understood you"

• Hey Mycroft, stock price for Boeing Company

  "I'm sorry, I don't understand"

• Hey Mycroft, stock price for Citigroup

  "I don't understand, but I'm learning new things everyday"

• Hey Mycroft, stock price for Delta Airlines

  "delta airlines doesn't exist or has no stock price."

---

After I tried Petroleo Brasiliero, none of the Utterances worked after that ...

[KathyReid]

I retested this after discussion with Ake, I retested these and found what I'd done wrong. The vocab does not allow for the phrase stock price FOR {{company}}, only stock price OF {{company}}. All the examples that failed were using FOR not OF.

Retesting shows:

• Hey Mycroft, stock price of Alcoa

  "With ticker symbol AA, the current price of Alcoa Corp is 17.065 dollars per share."

• Hey Mycroft, stock price of Boeing Company

  "Doesn't exist or has no stock price."

• Hey Mycroft, stock price of Citigroup

  "Citigroup Inc, with ticker symbol C is currently trading at 66.71 dollars per share."

• Hey Mycroft, stock price of Delta Airlines

  "Doesn't exist or has no stock price"

• Hey Mycroft, stock price of Deutsche Bank

  "Deutsche Bank FI Enhanced Global High Yield , with ticker symbol FIEG is currently trading at 0 dollars per share."

---

This was an issue with .voc, NOT the commits in this PR.

[KathyReid]

LGTM, merging. Side note, I've raised a separate PR for the phrasing I tripped up on. See #7