MycroftAI / skill-stop

Mycroft AI official Stop Skill - stop the actions of a Skill that are in progress
https://mycroft.ai/skills
Apache License 2.0
8 stars 26 forks source link

Add and fix missing french translation #48

Closed goldyfruit closed 2 years ago

goldyfruit commented 2 years ago

Add and fix French translation.

krisgesling commented 2 years ago

Hey Gaëtan, with the accents, I presume you're seeing most STT services returning transcripts without them?

Happy to go with what works in the most cases for now. But wondering if this is something we should be mindful of when building out improved translation layers? Should we support both accented and non-accented forms?

goldyfruit commented 2 years ago

@krisgesling I got weird behavior with the accents, not sure why (yet), for example I'm not able to stop the speaking.

krisgesling commented 2 years ago

Is the STT returning non-accented strings? Or even with accents in the utterance string you are still seeing problems?

goldyfruit commented 2 years ago

@krisgesling seems to work with the accent now, I'm confused... I reverted all the changes related to the accents in my PR.

image

2022-09-28 20:47:25.278 | DEBUG    |     1 | mycroft.skills.intent_service:_normalize_all_utterances:72 | Utterances: [('arrêter',)]
2022-09-28 20:47:25.303 | DEBUG    |     1 | mycroft.skills.intent_services.padatious_service:_match_level:47 | Padatious Matching confidence > 0.95
2022-09-28 20:47:25.384 | DEBUG    |     1 | Mark2 | Stop received
2022-09-28 20:45:21.336 | DEBUG    |     1 | mycroft.client.speech.listener:transcribe:224 | STT: arrêter
2022-09-28 20:45:21.341 | INFO     |     1 | __main__:handle_utterance:76 | Utterance: ['arrêter']

It worked by voice as well...

krisgesling commented 2 years ago

Yeah weird... I'm guessing that this will be a problem with certain STT's though. So good thing for us to think about in the future.

Edit: same with hyphenated words, I can easily see scenarios where some engines return hyphenated, others return with a space.