query handler: level set using __volume_to_level

MycroftAI / skill-volume

Mycroft AI official Volume Skill - control the volume of your Device

https://mycroft.ai/skills

Apache License 2.0

10 stars 30 forks source link

query handler: level set using __volume_to_level #32

Closed krisgesling closed 5 years ago

krisgesling commented 5 years ago

A possible solution to simplify handle_query_volume

get current volume from mixer
convert to Mycroft level

This resolves the issues I was seeing where levels 6-11 would be reported back as one level lower. Level 1 would report back as 8. However I don't really understand why the existing line was __get_volume_level and passing in the message so I may not be catching all cases.

forslund commented 5 years ago

This looks correct and still works fine for me. I'll merge and update the PR to mycroft-skills