search

MycroftAI / skill-volume

Mycroft AI official Volume Skill - control the volume of your Device
https://mycroft.ai/skills
Apache License 2.0
10 stars 30 forks source link

Allow users to specify a default volume #69

Closed lnguyenh closed 4 years ago

lnguyenh commented 4 years ago

Description

Allow users to specify a preferred volume every time Mycroft starts. Maybe nice to have? Volume is specified as a percentage, and is available in a new section, under the "Ducking" section when the user goes here: https://account.mycroft.ai/skills. Quite handy to avoid confusion if for some reason the volume was set super low before the last reboot, and to be able to set the volume one likes right from the start (I personally always need to lower a tad the hardcoded default volume).

Type of PR

Testing

Manual testing by blacklisting the official volume skill, adding the new one, and verifying that 1) it boots as it should and 2) in the cli we can check that the volume is set correctly. In the cli, testing increasing, decreasing the volume, and the automated tests should not fail either to verify that we didnt break anything.

Documentation

No existing docstrings to update

CLA

[x]

lnguyenh commented 4 years ago

Ok, just seeing now that there is another similar PR :). This one uses volume as a percentage instead of level, which is arguably better for the user. But I also read in the comments that the skill may be restructured, and that the default setting should maybe be at the device level. Feel free to close this PR :)