search

MycroftAI / skill-volume

Mycroft AI official Volume Skill - control the volume of your Device
https://mycroft.ai/skills
Apache License 2.0
10 stars 30 forks source link

Add missing translation for French #85

Closed goldyfruit closed 2 years ago

goldyfruit commented 2 years ago

Since PR #77, the _translate_volume_words() function has been added which raise a warning if volume.words.value is missing.

This PR the warning for the French language.

krisgesling commented 2 years ago

Thanks Gaëtan,

My only question is whether "silencieux" is the right term - note I don't speak French - it just seems to translate to "silent" so thought it worth double checking as it will set the volume to 30%.

goldyfruit commented 2 years ago

@krisgesling yes, according to the comment in __translate_volume_words():

Any words in volume.words.value must also be contained in Level.voc

In Level.voc, the word used is silencieux, https://github.com/MycroftAI/skill-volume/blob/21.02/vocab/fr-fr/Level.voc