WIP: Refactor Skill to remove duplication and reduce complexity

MycroftAI / skill-weather

Mycroft AI official Weather Skill, providing weather conditions and forecasts.

https://mycroft.ai/skills

Apache License 2.0

19 stars 59 forks source link

WIP: Refactor Skill to remove duplication and reduce complexity #143

Closed krisgesling closed 3 years ago

krisgesling commented 4 years ago

This is a refactor of the Skill intended to clean up the code in preparation for some bug fixes and upgrading to the newer PyOWM library.

Currently this includes:

extracting and documenting the existing OWM API
extracting utility functions (there seems to be some bugs in here)

PR created to warn everyone of the impending change.

chrisveilleux commented 3 years ago

Thanks for this initial effort to get me started, @krisgesling. Closing this ticket in favor of the full refactor in the "make-weather-great-again" branch.