search

MycroftAI / skill-weather

Mycroft AI official Weather Skill, providing weather conditions and forecasts.
https://mycroft.ai/skills
Apache License 2.0
19 stars 59 forks source link

Improved Polish language support #152

Open r0d0dendr0n opened 3 years ago

r0d0dendr0n commented 3 years ago

Description

Added a language strings for extracting dates from constant relative date strings like "today". Adds a reasonably good Polish language support for weather related queries.

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR. Either delete those that do not apply, or add an x between the square brackets like so: - [x]

Testing

Set Mycroft to Polish and ask "Jaka będzie jutro pogoda" or "czy przyda mi się parasol w przyszły weekend".

Documentation

There is no documentation for this skill.

CLA

My CLA has already been submitted.

r0d0dendr0n commented 3 years ago

It's worth noting that one needs to invoke: mycroft-config set load_langs_on_demand True for lingua_franca to properly load English, along with your primary non-English language. Otherwise you will get a an exception from lingua_franca. Maybe there are other ways that I am not aware of.

r0d0dendr0n commented 3 years ago

Actualy you need to manualy set load_langs_on_demand = True on config.py of lingua_franca and restart Mycroft. Kind of sucks that lingua_franca seems borked for now.

krisgesling commented 3 years ago

I think for mycroft-core we should be loading English for all installs, simply because that has been a long term assumption in it's development.

The intention is to have this occur in core as that's the code base requiring English, rather than require anyone using LF load English when they have no reason to need it.

Again thanks for flagging it