search

MycroftAI / skill-weather

Mycroft AI official Weather Skill, providing weather conditions and forecasts.
https://mycroft.ai/skills
Apache License 2.0
19 stars 59 forks source link

remove broken idle screen #154

Closed AIIX closed 3 years ago

AIIX commented 3 years ago

Description

Removes idle screen registration and not working idle screen for skill, seems to be a left over from testing, causes weather skill to be listed under homescreen in additional settings, using it does not work

Type of PR

If your PR fits more than one category, there is a high chance you should submit more than one PR. Please consider this carefully before opening the PR. Either delete those that do not apply, or add an x between the square brackets like so: - [x]

Testing

Weather should not show up under homscreen in additional settings

CLA

[x] yes

forslund commented 3 years ago

This was only there for testing purposes so should definitely be removed. Maybe remove ui/idle.qml as well?

AIIX commented 3 years ago

This was only there for testing purposes so should definitely be removed. Maybe remove ui/idle.qml as well?

has been removed

devops-mycroft commented 3 years ago

Thanks - will be good to add a new one in at some point, but good to remove this.