MycroftAI / skill-weather

Mycroft AI official Weather Skill, providing weather conditions and forecasts.
https://mycroft.ai/skills
Apache License 2.0
19 stars 59 forks source link

wrong output in build_condition_dialog with non-english language #204

Open lcipria opened 2 years ago

lcipria commented 2 years ago

Describe the bug Mycroft answers with "condition-not-expected" dialog if condition matches the weather

To Reproduce Steps to reproduce the behavior:

  1. Apply PR #203
  2. Set Mycroft languate to Italian
  3. Ask for "Piove?" (it rains?) in a rainy day or similar behavior

Expected behavior Output should be "condition-expected"

Log files ...

Environment (please complete the following information):

Additional context The problem seems to be related to this row:

intent_match = self.voc_match(weather.condition.category.lower(), condition)

krisgesling commented 2 years ago

Hey, thanks for the detective work.

Will need to check what languages OpenWeather handles. Alternatively we do all the API interaction in english and translate the localized condition term to the base english condition for comparison.