Where does bad Korean translation come from?

JuliaC29 commented 5 years ago

In my ko-kr/current.local.weather.dialog file I have:

현재 {{condition}}고 기온은 {{temp}}도입니다. 오늘의 최고 기온은 {{temp_max}}도, 최저 기온은 {{temp_min}}도입니다.

When I ask mycroft the weather, I get:

날씨가 어때?
현재 맑음고 기온은 6도입니다. 오늘의 최고 기온은 6도, 최저 기온은 0도입니다.

I don't find the string 맑음 anywhere in my code.

juyeon@ju:/opt/mycroft/skills/mycroft-weather.mycroftai$ grep -nHr 맑음 . | wc -l
0

It is not correct Korean in this context. It should be 맑. Is this coming from OWM ? Is there a way to override what they send ?

KathyReid commented 5 years ago

Hi @JuliaC29, in order for us to diagnose this we will need to see your skills.log. Are you able to provide this for us please?

https://mycroft.ai/documentation/troubleshooting/#how-to-find-the-mycroft-logs

forslund commented 5 years ago

Hi @JuliaC29 it is most likely the OWM translations that was added recently. (PR #52) If you feel it's better to not use the korean translation from OWM we can remove L675 and remove 'kr' from L683

chrisveilleux commented 3 years ago

Is this still an issue?

MycroftAI / skill-weather

Where does bad Korean translation come from? #59