search

MycroftAI / skill-weather

Mycroft AI official Weather Skill, providing weather conditions and forecasts.
https://mycroft.ai/skills
Apache License 2.0
19 stars 59 forks source link

Fix: Long locations not recursively searching #92

Closed krisgesling closed 5 years ago

krisgesling commented 5 years ago

For some reason a 404 response is sometimes returned as a JSON-like string and doesn't raise a HTTPError thereby avoiding the recursive search.

I have currently left the existing except block in assuming that this may also trigger depending on the search.

Also small update to the __get_location doc string to properly reflect the returned data.

To test

Ask for the "weather in Sydney Australia" or "weather in Johannesburg South Africa". Without change - no response. With change - recursively searches and returns location as Sydney and Johannesburg respectively.

forslund commented 5 years ago

Looks good, I'll add an issue to the backend seems like they lose the status from OWM during proxying.