search

MycroftAI / snapcraft-mycroft-core

This project is for building mycroft-core snaps
MIT License
13 stars 11 forks source link

Build for 32- and 64-bit x86 and ARM #25

Open strugee opened 4 years ago

strugee commented 4 years ago

AMD64 builds are obviously already tested since that's what's in the Snapcraft Store already. I'm going to test the armhf build shortly, locally on my Pi. I added in i386 and arm64 builds since I figured they're close enough to what was already tested, but I didn't add s390x or ppc64el (the other two valid snappy architectures) because they're completely disparate architectures and I have no way to test them.

I'm marking this as draft for the time being since it seems like my build is working, but I'm actually still waiting for it to finish so I can test it out.

Fixes #24

strugee commented 4 years ago

Whelp, turns out the cmake plugin does not support cross-compilation. So I wasn't able to test this. (I tried to build it directly on my Pi, but unfortunately snap install balked at some missing kernel confinement support.) So I guess the Launchpad CI is the only way to distribute ARM builds...?

Marking as ready for review because I think probably the best way to do this is to just push this to the beta channel in the Snapcraft store and see if any users report breakage. The code clearly already runs on armhf anyway, so I doubt there'll be any breakage.

krisgesling commented 4 years ago

Hey strugee, you should be able to use the Launchpad services with snapcraft remote-build to test it out on different architectures.

From memory this was failing and we just wanted to get up and running so marked it to build only for amd64. There's a few hardcoded values that would need to change in the snapcraft yaml like the Precise download.

We should also remove the jsonnet as we haven't been building off that, so fairly sure it's out of sync with the snapcraft.yaml