search

Mydayyy / Valheim-ServerSideMap

This plugin completely moves the explored map and created pins to the server. As clients explore, they will send their explored areas to the server who will then distribute it to all connected clients. When a client joins, the server will synchronize the currently explored areas to the client. Pins are shared as well but default to false and need to be enabled. When pin sharing is used, all newly created pins are send to the server who saves them along with the explored area.
38 stars 1 forks source link

Incompatibility with Universal Portals #35

Closed Mydayyy closed 3 years ago

Mydayyy commented 3 years ago

Reported on NexusMods:

first off, AMAZING mod! Biggest thanks for this! Second, we have been using this on our dedicated server for a while now, with no issues, but when we added a few mods, we noticed one incompatibility I felt should be mentioned. Universal Portals, first config option (something about map pins) makes all the map pins we've set disappear permanently. Gone forever, poof. NBD on this map as we're just starting so there's only about 4 pins right now, but later, or on our other map, would be catastrophic. Is there a way that map pins could be backed up without saving a copy of the map from the user files? I've turned off the option on the other mod, and map pins are saving again, but I wanted to be sure to report this so others don't loose their pins.

Mydayyy commented 3 years ago

Summary:

Issue seems to be that Universal Portals seems to be removing all MapPins and readding them immediately. ServersideMap is configured in a way, where all pin deletions are sent to the server, but for pin creations, only manual ones are synced. This leads to a total loss of pins in when used together with UP and the ShowPortalsOnMap feature.

Solution:

Only sync manual pin deletions to the server. This is more consistent anyways, since only manual pin creations are synced too.

Mydayyy commented 3 years ago

Fix landed in 2ebf7e1bf5f42311ed832a3a71f4649f02ffda56 currently awaiting feedback

Mydayyy commented 3 years ago

Confirmed the fix is working, released as 1.3.1