Mydayyy / Valheim-ServerSideMap

This plugin completely moves the explored map and created pins to the server. As clients explore, they will send their explored areas to the server who will then distribute it to all connected clients. When a client joins, the server will synchronize the currently explored areas to the client. Pins are shared as well but default to false and need to be enabled. When pin sharing is used, all newly created pins are send to the server who saves them along with the explored area.
38 stars 1 forks source link

Introduce hotkey for sharing pins? #39

Closed Amar1729 closed 2 years ago

Amar1729 commented 3 years ago

Is it possible this mod could introduce a hotkey for sharing pins (with/without dupes)?

I looked into a similar mod, Explore Together, that has hotkeys for sharing map or pin progress but I'm not sure of all the code necessary to implement it in this mod.

Mydayyy commented 3 years ago

Greetings,

yes in theory this would be possible, I do have trouble seeing the use case for this currently. The goal of this mod is to sync the pins basically on creation to the server, so they only exist on the server instead of the client.

The only need to sync local pins to the server arises from mod-created pins (e.g locator, ...). This is currently possible via a chat command. Do you find yourself running this chat command often and are looking for a hotkey solution?

Best Regards Mydayyy

Amar1729 commented 3 years ago

Yup, a few friends and I are using Locator alongside this mod actually. We try to sync pins before we log out, but we're finding that ideally they would just be synced quietly/via hotkey while exploring.

Another problem that arises with the use of Locator specifically is that we end up having quite a few duplicate pins / pins that are very close together and basically duplicates, and so some of us have been wanting a hotkey for /convertpins ignorelocaldupes as well, or a config option to always ignore duplicates (although I get it if you feel its outside the scope of the mod).

Mydayyy commented 3 years ago

Sorry for the late reply, the weekend basically blew past me <.<

I'd love to implement this. From what I gather, another idea would be the ability to toggle a flag via the config, to automatically sync pins when logging out instead of a hotkey. What of those two do you think makes the most sense?

Best Regards Mydayyy

Amar1729 commented 3 years ago

No worries! I think ideally both of those would be an option - while using this mod with Locator, my friends have found that sometimes we'd like to sync things we've recently found - such as nearby copper deposits - while in a fight with a ton of enemies.

I think that having the hotkey first be the better user-interface solution, while having the sync-on-logout option a nice catch for when people forget to sync at the end of a day exploring.

Mydayyy commented 3 years ago

Hello,

I released a new RC here: https://github.com/Mydayyy/Valheim-ServerSideMap/releases/tag/rc-1.3.3

To test the hotkey functionality, it is enough to only update the client. It is fully backwards compatible and you don't necessarily need to update the server right away. I will implement the auto-sync on logout functionality on the weekend.

Best Regards Mydayyy

Mydayyy commented 2 years ago

Went live in 1.3.5

Amar1729 commented 2 years ago

Thanks very much for your work on this! Forgot to update this issue after trying it out.