search

Mydayyy / Valheim-ServerSideMap

This plugin completely moves the explored map and created pins to the server. As clients explore, they will send their explored areas to the server who will then distribute it to all connected clients. When a client joins, the server will synchronize the currently explored areas to the client. Pins are shared as well but default to false and need to be enabled. When pin sharing is used, all newly created pins are send to the server who saves them along with the explored area.
38 stars 1 forks source link

Bug: Switching between worlds overlays map markers onto unrelated map #41

Open rakheepatel opened 3 years ago

rakheepatel commented 3 years ago

There's a buggy behaviour where jumping between worlds on the same game session overlays map pins, i.e. if I log out of world1 and log into world2, then I see world1's map markers overlaid on world2's map. Only way to fix it right now is to quit Valheim and restart in world2.

  1. With the mod (v1.3.1) loaded, start the game and go into a world with map markers
  2. Open the map
  3. Close the map and Log Out (retain the game session)
  4. Open another world with map markers using a character who has made markers there (it could be the same character, or maybe you have made one for each world. I used a different character)
  5. Open the map. Notice there are markers that shouldn't be here, most obvious when markers appear in fogged parts of the map

Expected result: Map should only show markers for its own map

Actual result: Map is showing markers for another map

Screenshots:

Map 1 Character 1: image

Map 2 Character 2: image

Mydayyy commented 3 years ago

Greetings,

this should too be fixed with the new rc: rc-1.3.4.

Best Regards Mydayyy

rakheepatel commented 3 years ago

Maps now retain their own markers, however I found that some of my markers are missing. Here are some before and after screenshots:

Before rc-1.3.4 Map 1 Character 1: image

After rc-1.3.4 Map 1 Character 1: Vbugmap3

Maybe something got lost in the translation with ignoring local dupes?

Mydayyy commented 3 years ago

Looked into this and I can not reproduce any loss of pins so far. Is this a permanent loss or do they show up again e.g after restarting the game?

Also followup: Is the missing marker issue related to downloading the pins? Or is it only when switching between sessions

rakheepatel commented 3 years ago

Hey, sorry for the delayed reply. The loss of markers is permanent, they didn't come back. I have no way of knowing whether they went missing because of a download error or something else. I even switched the dll back to the previous one, but the markers were still missing. Switching between sessions has no effect on bringing back the missing markers, switching sessions is retaining markers of the respective maps as per the other issue you fixed.

In the grand scheme of things I'm only playing this casually so I'm not heartbroken about my markers missing, but I'd probably get some others to test this release a bit more. I'd hate for this to be merged only to cause issues with other players' map markers too.