Mydayyy / pbcli

pbcli is a command line client which allows to upload and download pastes from privatebin directly from the command line.
MIT License
10 stars 4 forks source link

Do not trip on new `warn before read` feature #14

Closed nain-F49FF806 closed 2 months ago

nain-F49FF806 commented 2 months ago

Upstream privatebin introduced this new feature https://github.com/PrivateBin/PrivateBin/pull/1237

If the fragment contains a prefix character - , then the ui is supposed to warn before actually getting paste, as the paste may be burn on read.

source

This character can trip our reading of the bs58key. So, strip the prefix if found.

Mydayyy commented 2 months ago

Greetings,

thank you for spotting and fixing this, I did not know about that feature. I saw that you made a comment upstream. I'll be merging this since the current upstream implementation is a dash. Something to keep an eye on I figure.

Thank you for your contribution

Best Regards Mydayyy