search

Mydayyy / pbcli

pbcli is a command line client which allows to upload and download pastes from privatebin directly from the command line.
MIT License
11 stars 4 forks source link

Expose as library so others can use the defined structs and accompanying code #4

Closed nain-F49FF806 closed 6 months ago

nain-F49FF806 commented 6 months ago

This way, the code would be useable by other devs / applications.

Particularly, with UniFFI bindings (tbd.), this library may make it possible to create clients using Kotlin / Compose Multiplatform etc.

Mydayyy commented 6 months ago

Greetings,

thank you for your contribution. I will review it this weekend and get back to you

Best Regards Mydayyy

Mydayyy commented 6 months ago

Greetings,

I do not have experience with UniFFI, so I am not able to say whether the changes work properly there, but the changes itself are a good addition and make sense. I will merge this PR and proceed to release a patch update v2.3.1 here, on AUR and on the crate repository during the course of the day.

Thank you again for your contribution.

Best Regards Mydayyy

nain-F49FF806 commented 6 months ago

Thanks for the review and merging it in so swiftly.

These changes do not specifically enable UniFFI by themselves. It's something I intend to add later. Exposing as library would be a prerequisite for that, and so this is a first step in that direction. With the additional benefit of making it generally useable.

If I get the UniFFI working, I'll share another PR :)

Bestest Regards.