MykalBaytaluk / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.
https://learn-the-web.algonquindesign.ca/courses/web-dev-4/pattern-library-set-up/
0 stars 0 forks source link

Request for grade #3

Open MykalBaytaluk opened 6 years ago

MykalBaytaluk commented 6 years ago

@thomasjbradley

Although I learned a lot from this pattern library assignment, and would feel completely comfortable doing it all over again, I know that there was so much more effort that could have been put into the assignment.

My semantics are strong as well as general cleanliness of my code and my design was clean and understated with plenty of room for growth surrounding a clean and simple grid. But thats just it, there was so much room for growth that I know I deserve no more than a 65-70%. With just a little more work, the website would have looked much more unified and complete.

The good news is that I now feel comfortable enough to jump into atom and github, if need be, and work on a team to make something real. The concepts are understood and appreciated but the follow through could use more love. Goal for the summer, I suppose.

Thanks and all the best. Mykal


Style & design3

The style and design of the website is clean and fits with the aim of the brand.

Patterns1

There was definitely room for more patters to be made to make it easier to make an entire website. There was also room to break apart a few of the larger pages into smaller, easier to change, patterns.

Explanations0

There were explanations missing on multiple pages.

Accessibility1

Plenty more time and detail could have been put into ensuring accessibility standards.

Semantics3

Semantics are strong throughout, hardly any css was used because of the strength of html tags.

Responsiveness3

Lots of effort went into making sure that the content/patterns, especially the ones that repeat on every page of the website, were as responsive as possible while ensuring the standards of the desired brand.

Code Quality3

Indentation and semantics feel like second nature, and the code is consistent throughout all pages.

Git & Commits2

Although the semantics of the commits were good, there was room for there to be many more commits made.


16/24 — 66%