search

Mykindos / BetterPvP

18 stars 23 forks source link

Update SkillListener.java #1034

Closed TR4E closed 1 month ago

TR4E commented 2 months ago

Describe your changes

Changing getClassType() to "Skill" makes more sense, considering things like "Cannot use while in liquid." is not a ClassType type of restriction, it's a overall "Skill".

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ezrn commented 2 months ago

come to think of it, why is it "liquid" when it only applies to water

Mykindos commented 1 month ago

This is in a lot more places than just this, e.g. Deblink also uses the class name.

Happy with how it is for now