Mykindos / BetterPvP

18 stars 23 forks source link

Add a way to view all special items #1067

Open StudentAlleg opened 1 month ago

StudentAlleg commented 1 month ago

Add a way to view special items with a command. Prototype 1 shows all items, except tools, by using BPvPItem#getItemStack and ItemHandler#UpdateName, sorted by identifier. Does not show ranges (i. e. runes/hyper), does not group runes/legends. Only 2 rows of viewing. A somewhat quick and dirty implementation.

Notes: This is something very much implementable, just depends on the amount of time that should be spent implementing. Prototype 1 is better than nothing, and gives players more information, but could be improved,

Fixes #1052

Checklist before requesting a review

StudentAlleg commented 1 month ago

Current Status: Now sorts Legends and Runes to be grouped together, in the beginning. Hyper Axe shows stat variation, and Runes are being worked on. Potential Issues: It is currently not a singleton, so is loaded everytime the player runs the command. The items are the actual items, which means potential for duping.

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.9% Duplication on New Code

See analysis details on SonarQube Cloud