search

MynaWallet / contracts

10 stars 2 forks source link

Integration of Solhint for Enhanced Solidity Code Quality #20

Open susumutomita opened 11 months ago

susumutomita commented 11 months ago

This pull request addresses Issue #19 by integrating Solhint, a linter for Solidity, into our project. The inclusion of a linter is crucial as our project continues to involve more smart contract development on Ethereum. Here are the key changes made in this PR:

Changes

It's worth noting that upon running Solhint, numerous linting errors were identified across our Solidity files. Addressing these errors is important for improving the overall code quality of our project. However, to keep this PR focused and manageable, I plan to address the linting errors in a separate follow-up PR. This approach will also allow us to discuss and potentially adjust our Solhint configuration or coding standards as needed before correcting all identified issues.

motemotech commented 11 months ago

@susumutomita Sry, I don't migrate this change to new repo, since we use foundry as a main tool and foundry is not really friendly to npm packages. Could you find a good linter for forge command and post PR againt to new repo?